Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release_timestamp for atom feed entries #959

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

bilbof
Copy link
Contributor

@bilbof bilbof commented Mar 14, 2019

If public_timestamp is not available we will try to use release_timestamp. This is only useful for upcoming stats which don't have a public timestamp, but do have a release timestamp.

https://trello.com/c/8D4Y1ye5/522-fix-upcoming-stats-atom-feed

View the change at: /search/statistics?parent=&keywords=&level_one_taxon=&content_store_document_type=statistics_upcoming&public_timestamp%5Bfrom%5D=&public_timestamp%5Bto%5D=&order=updated-newest

If public_timestamp is not available we will try to use
release_timestamp. This is only useful for upcoming stats
which dont have a public timestamp, but do have a release
timestamp.
@bilbof bilbof added the do-not-merge Indicates that a PR should not be merged into master / release branches label Mar 15, 2019
@bilbof bilbof changed the title Use release_timestamp for atom feed entries [do not merge] Use release_timestamp for atom feed entries Mar 15, 2019
@bilbof
Copy link
Contributor Author

bilbof commented Mar 15, 2019

I've added a do not merge label as I'm awaiting approval from a product perspective; it's possible we don't want email/atom feeds for upcoming statistics.

@bilbof bilbof changed the title [do not merge] Use release_timestamp for atom feed entries Use release_timestamp for atom feed entries Mar 19, 2019
@bilbof bilbof removed the do-not-merge Indicates that a PR should not be merged into master / release branches label Mar 19, 2019
@bilbof bilbof merged commit 2bbff2c into master Mar 19, 2019
@bilbof bilbof deleted the enable-release_timestamp-atom branch March 19, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants