Make A/B test meta tag consistent with Google Analytics JS #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat the meta tag which specifies user's bucket for the A/B example test so that it matches the format expected by the analytics JavaScript code in `static`. The previous format was only parsed by `govuk-toolkit-chrome`, but that code has not been released yet so it's safe to change this tag and then update the Chrome plugin.
This was referenced Jan 27, 2017
tijmenb
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat the meta tag which specifies user's bucket for the A/B example test so that it matches the format expected by the analytics JavaScript code in
static(see alphagov/static#888)The previous format was only parsed by
govuk-toolkit-chrome, but that code has not been released yet so it's safe to change this tag and then update the Chrome plugin.Trello: https://trello.com/c/g9OyC7Pn/310-tell-google-analytics-about-a-b-tests
Once this is merged: