Use govuk-components for help page related links #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In static we removed the CSS for the old sidebar, but the help page index was stilling using it: https://www.gov.uk/help It should have looked like this: http://webarchive.nationalarchives.gov.uk/20151109153250/https://www.gov.uk/help Using the govuk-component fixes this.
|
👍 |
tijmenb
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In static we removed the CSS for the old sidebar, but the help page index was stilling using it:
https://www.gov.uk/help
It should have looked like this:
http://webarchive.nationalarchives.gov.uk/20151109153250/https://www.gov.uk/help
Using the govuk-component fixes this.
Before:
After:
Trello: https://trello.com/c/QFUjiqHs/449-fix-related-links-for-help-pages
Paired with @klssmith @Davidslv
We've left out the "return to top" link as it wasn't there beforehand, and it doesn't seem to serve any purpose.