Fix search bug on foreign travel advice page #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a keydown event listener to the CountryFilter function. The event listener triggers on keydown and prevents the default form behaviour when the Enter key is pressed and cleared the results. - Keyup event listener is retained to handle filtering functionality
CodeSonia
force-pushed
the
fix-bug-search-behavior-on-foreign-travel-advice-page
branch
from
b93d714
to
0a5d623
Compare
CodeSonia
changed the title
MartinJJones
approved these changes
May 31, 2024
MartinJJones
deleted the
fix-bug-search-behavior-on-foreign-travel-advice-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
keydownevent listener to theCountryFilterfunction to prevent the default form submission behaviour when the Enter key is pressed.keyupevent listener to handle filtering functionalityforeign_travel_advice_spec.jsnow checks forkeydownevent instead ofkeyupwhen Enter key is pressed.travel_advice_test.rbwhere assertions are updated to reflect the visibility changes in the country list items.Why
Trello card
Previously, the keyup event listener was solely responsible for handling both form submission prevention and filtering. However, a bug was found where if you typed "Spain" in the search and press Enter, the results are cleared and the URL retains the search term.
Visual Changes