Turn CSRF protection on by default #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rails default CSRF protection was disabled in #4123 The POST routes in this application are postcode lookups to an external API. So we don't currently need CSRF protection, but this is being flagged by the scanner as a vulnerability. Let's turn it back on across the application, and just disable it on four specific routes. This means if the application changes in the future we aren't caught out (assuming we're covered by default CSRF protection).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rails default CSRF protection was disabled in #1317
The POST routes in this application are postcode lookups to an external API. So we don't currently need CSRF protection, but this is being flagged by the scanner as a vulnerability. Let's turn it back on across the application, and just disable it on four specific routes. This means if the application changes in the future we aren't caught out (assuming we're covered by default CSRF protection).
https://trello.com/c/HQaHFTdc/2580-review-and-potentially-fix-code-scanning-alerts-for-our-repos-m