Merge pull request #824 from alphagov/remove-nav-helper-stubbing

Update nav helpers to 9.1.0

Gemfile

@@ -17,7 +17,7 @@ gem 'gds-api-adapters', '~> 51.4'
 gem 'govuk_ab_testing', '~> 2.4'
 gem 'govuk_app_config', '~> 1.3'
 gem 'govuk_frontend_toolkit', '~> 7.4'
-gem 'govuk_navigation_helpers', '~> 9.0'
+gem 'govuk_navigation_helpers', '~> 9.1.0'
 gem 'govuk_publishing_components', '~> 5.4.0'
 gem 'plek', '~> 2.1'
 gem 'slimmer', '~> 12.0'

Gemfile.lock

@@ -123,7 +123,7 @@ GEM
     govuk_frontend_toolkit (7.4.2)
       railties (>= 3.1.0)
       sass (>= 3.2.0)
-    govuk_navigation_helpers (9.0.0)
+    govuk_navigation_helpers (9.1.0)
       activesupport (~> 5.1)
       gds-api-adapters (>= 43.0)
       govuk_ab_testing (~> 2.4)
@@ -360,7 +360,7 @@ DEPENDENCIES
   govuk_ab_testing (~> 2.4)
   govuk_app_config (~> 1.3)
   govuk_frontend_toolkit (~> 7.4)
-  govuk_navigation_helpers (~> 9.0)
+  govuk_navigation_helpers (~> 9.1.0)
   govuk_publishing_components (~> 5.4.0)
   govuk_schemas (~> 3.1)
   htmlentities (~> 4.3)

test/controllers/content_items_controller_test.rb

@@ -290,34 +290,6 @@ class ContentItemsControllerTest < ActionController::TestCase
     refute_match(/A Taxon/, taxonomy_sidebar)
   end
 
-  test "shows the taxonomy-navigation if tagged to taxonomy" do
-    GovukNavigationHelpers::ContentItem
-      .stubs(:whitelisted_root_taxon_content_ids)
-      .returns(["aaaa-bbbb"])
-
-    content_item = content_store_has_schema_example("document_collection", "document_collection")
-    path = "government/abtest/document_collection"
-    content_item['base_path'] = "/#{path}"
-    content_item['links'] = {
-      'taxons' => [
-        {
-          'title' => 'A Taxon',
-          'base_path' => '/a-taxon',
-          'content_id' => 'aaaa-bbbb',
-        }
-      ]
-    }
-
-    # GovukNavigationHelpers::NavigationHelper.taxonomy_sidebar makes requests
-    # to Rummager for related content for given taxons
-    stub_any_rummager_search
-
-    content_store_has_item(content_item['base_path'], content_item)
-
-    get :show, params: { path: path_for(content_item) }
-    assert_match(/A Taxon/, taxonomy_sidebar)
-  end
-
   test "Case Studies don't have the taxonomy-navigation" do
     content_item = content_store_has_schema_example('case_study', 'case_study')
     path = 'government/test/case-study'