Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav helpers to 9.1.0 #824

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Update nav helpers to 9.1.0 #824

merged 2 commits into from
Mar 14, 2018

Conversation

steventux
Copy link
Contributor

@steventux steventux commented Mar 13, 2018

This PR should unblock the upgrade path for govuk_navigation_helpers

  • Updates govuk_navigation_helpers to version 9.1.0
  • Removes a test relying on internals of the nav helpers gem

Example with taxonomy nav:

https://government-frontend-pr-824.herokuapp.com/government/publications/developing-quality-tuition-effective-practice-in-schools-free-school-meals

Example which shouldn't show taxonomy nav:

https://government-frontend-pr-824.herokuapp.com/government/case-studies/dfid-research-milking-the-benefits-for-small-scale-dairy-vendors-in-kenya


Component guide for this PR:
https://government-frontend-pr-824.herokuapp.com/component-guide

@tijmenb tijmenb merged commit ee6fe91 into master Mar 14, 2018
@tijmenb tijmenb deleted the remove-nav-helper-stubbing branch March 14, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants