Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show closing date on unopened consultations #203

Merged
merged 1 commit into from Dec 2, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 2, 2016

The date that the consultation closes is useful information for users.

screen shot 2016-12-02 at 11 42 56

@andrewgarner

The date that the consultation closes is useful information for users.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-203 Dec 2, 2016 Inactive
@andrewgarner
Copy link
Contributor

@andrewgarner andrewgarner commented Dec 2, 2016

Should / could you get the dividing line to fill the height of the container (minus the padding)?

@fofr
Copy link
Contributor Author

@fofr fofr commented Dec 2, 2016

Not easily, I don't think the complexity it'd add justifies it. This matches what's live. I toyed with not including the border at all when I was building the template, which would look like this:

screen shot 2016-12-02 at 11 58 32

@andrewgarner
Copy link
Contributor

@andrewgarner andrewgarner commented Dec 2, 2016

👍

@fofr fofr merged commit cb8f5df into master Dec 2, 2016
1 check passed
1 check passed
default Build #971 succeeded on Jenkins
Details
@fofr fofr deleted the closing-date-on-unopened-consultations branch Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.