Render nested contents for specialist documents #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em dashes make each content item clearer in the list * Replace media query hack with `@supports` - IE9-11 will get disc bullets * Move list-style-type declaration next to @supports so it’s clear that it gets overridden * Add 5px to the margins to give extra space around the em dash
* Include a two level contents list (based on h2s and h3s) * Style the h2s without a list marker and in bold * h3s appear like standard contents lists * h4s and further, although appearing in the `headers` hash are not displayed – at this level the contents list stops being useful * Markup mostly ported from specialist-frontend * Move strip_trailing_colons into shared helper
This gives a better content outline, while the previous heading was valid, the HTML5 outline algorithm is not widely supported.
fofr
force-pushed
the
contents-design-update
branch
from
fb38deb
to
5358e38
Compare
|
Did you get Mia's eyes on the lack of emdash at the top level? |
|
@NickColley Yep. |
|
I seem to remember (might be wrong) that some of our other documents also have nested contents list, does this change only update specialist documents to have nested list behaviour? |
|
@NickColley No other format in government-frontend has nested contents. The existing contents list is always one level deep and remains the same. Nested contents only applies to specialist documents. |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/phs722pV/186-1-add-new-contents-list
headershash are not displayed – at this level the contents list stops being usefulOn older browsers that don't support
content:or@supports: