Add Rake task for PR visual regression comparison #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Should we add something to the Readme so people know they can do this? |
|
Updated with documentation and a task for comparing master. |
|
Found an issue with Wraith, documented here: bbc/wraith#536 |
NickColley
reviewed
Aug 29, 2017
| @@ -29,11 +29,13 @@ def build_paths | |||
| if @paths.is_a? Hash | |||
| @paths.keys.each do |key| | |||
| @paths.fetch(key).each_with_index do |path, index| | |||
| config_paths[path_index(key, index + 1)] = path | |||
| config_paths[path_index(key, index + 1)] = path unless path_blacklisted?(path) | |||
There was a problem hiding this comment.
This currently silently removes config, which could be really confusing. "Why is it not running this path!?" Could we log a message when a path is blacklisted so people know why we've not allowed this path?
Compare production and a review app hosted on Heroku. * Pass in a PR number to generate a config and run the test. * Run against the heroku deployment of master * Refactors wraith tasks to DRY up
Paths containing "path" in them break Wraith: bbc/wraith#536 Search API incorrectly returns government-frontend as renderer for travel advice index, this will always give a difference between live and a review app.
|
Is this PR still relevant now that there's alphagov/govuk-visual-regression#1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare production and a review app hosted on Heroku. Pass in a PR number to generate a config and run the test.
eg
bundle exec rake wraith:pr[450]update_document_typestask