This repository has been archived by the owner on May 6, 2020. It is now read-only.
Minimum viable component guide visual regression test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bbc/wraith#536 for detail
* Create a simple sinatra app * Respond to POST requests to /run * Capture webhook JSON from Github * Declare ruby in Gemfile for Heroku * Heroku doesn’t pick up the `.ruby-version` file
* Update config and runner to take domain params * Use friendly paths in gallery output
We can’t easily get a list of URLs for a component guide. Instead use the wraith spider feature and crawl the review domain’s component guide. Exclude paths that don’t start with /component-guide and only compare paths that end with `/preview` to limit the number of pages and speed up the test run. * Include rake tasks for running locally * Use Heroku runner in app
fofr
force-pushed
the
trigger-builds
branch
from
8b2bed1
to
d1cf92a
Compare
|
This doesn't cope well with multiple jobs running in parallel:
|
* Keep number of pages to test down to a minimum * Only test the pages that show all previews on one page eg: "/component-guide/contents-list/preview" but not: "/component-guide/contents-list/long_text/preview"
|
Added e9ff6ac to speed up each component guide test run. |
|
💯 🎉 |
fofr
added a commit
that referenced
this pull request
Jan 12, 2018
Use PR description from PR #1 as README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/run/run, pull out the environment from the deployment object and use it to set the domains for the wraith configSteps
government-frontend-pr-459How to test locally
bundle exec ruby app.rbFake a webhook, where
deployment_payload.jsonis the file in 210c55a:Part of:
https://trello.com/c/iXflEn6F/106-3-build-automated-visual-regression-proof-of-concept
Follow on from:
alphagov/government-frontend#458
alphagov/government-frontend#472
cc @NickColley