Add back link component #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses GOV.UK Frontend spacing units but rewrites internals to be simpler. Also includes hover state that looks like a regular link to satisfy our accessibility criteria for links.
Centralise forked GOV.UK Frontend variables. Change namespace to app, to be sure that these will not conflict with anything in the future.
NickColley
force-pushed
the
add-back-button-component
branch
from
4a48549
to
095606c
Compare
|
It feels a little small on smaller screens, so I'm going to address this. |
When testing on smaller screens such as mobile devices, the link was very small. This could make it harder to press.
tuzz
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Jan 5, 2018
Moved from government-frontend for use in email-alert-frontend Also renames the namespace to `gem` Originally implemented in alphagov/government-frontend#568
tuzz
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Jan 5, 2018
Moved from government-frontend for use in email-alert-frontend Also renames the namespace to `gem` Originally implemented in alphagov/government-frontend#568
tuzz
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Jan 5, 2018
Moved from government-frontend for use in email-alert-frontend Also renames the namespace to `gem` Originally implemented in alphagov/government-frontend#568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best viewed commit by commit.
Includes a refactoring to avoid duplicating variables and possible conflicts in the future.
https://government-frontend-pr-568.herokuapp.com/component-guide/back-link
Todo:
Default state
Hover state
Touch/focus state
As part of https://trello.com/c/vsmhbjLt/245-build-the-choose-sign-in-options-template-2