Extract the back_link component to govuk_publishing_components #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuzz
force-pushed
the
extract-back-link
branch
2 times, most recently
from
5a42889
to
72e1d0f
Compare
NickColley
reviewed
Jan 5, 2018
| .gem-c-back-link { | ||
| position: relative; | ||
| display: inline-block; | ||
| margin-top: $app-spacing-scale-3; |
There was a problem hiding this comment.
using $app- here should break, have you tried rendering this locally?
tuzz
force-pushed
the
extract-back-link
branch
from
72e1d0f
to
4cc7be0
Compare
NickColley
reviewed
Jan 5, 2018
| @@ -170,22 +166,23 @@ def render_component(locals) | |||
| end | |||
|
|
|||
| it "renders radio-group with welsh translated 'or'" do | |||
| I18n.default_locale = :cy | |||
| I18n.with_locale(:cy) do | |||
Moved from government-frontend for use in email-alert-frontend Also renames the namespace to `gem` Originally implemented in alphagov/government-frontend#568
tuzz
force-pushed
the
extract-back-link
branch
from
4cc7be0
to
ec8fac1
Compare
NickColley
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/HSre7K10/453-style-the-mvp-email-collection-page-needed-by-jan
Add Back Link component
Moved from government-frontend for use in email-alert-frontend
Also renames the namespace to
gemOriginally implemented in alphagov/government-frontend#568