This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Remove detect-secrets #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We installed this pre-commit hook to help prevent us from leaking production secrets, but the benefit hasn't outweighed the pain. I think we already solve this problem with good practices: 1. We don't share secrets between production and development/test envs. 2. We specify our production secrets in environment variables. So we've never been in the habit of committing real secrets to the repo. It seems strange that we'd slip up and do so now. Furthermore, as this is only a pre-commit hook, and not a pre-receive hook, it doesn't actually prevent someone from pushing a secret to GitHub! Since we have the same vulnerability whether have this hook or not, I don't think the potential gain (someone gets access to a production secret, hard-codes it, and then has that commit rejected before pushing it) is worth the effort (needing to keep the baseline and pragma comments up to date).
brucebolt
approved these changes
Jan 19, 2021
|
Yeah, I was up for this when we started out and were setting up a lot of things. Given the infrequency of the thing this was supposed to help with, and the amount of daily friction it adds. I think we could:
|
|
So I don't want to abandon safeguards, but I think we can do a bit more work to have ones that aren't so daily annoying... |
Yeah, it'd be good to have a bit of documentation on what sorts of secrets we have and how one could go about rotating them. |
barrucadu
added a commit
to alphagov/govuk-attribute-service-prototype
that referenced
this pull request
Jan 19, 2021
barrucadu
added a commit
that referenced
this pull request
Jan 27, 2021
We decided this was more trouble than it's worth, see #613
barrucadu
added a commit
to alphagov/govuk-account-team-manual
that referenced
this pull request
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We installed this pre-commit hook to help prevent us from leaking
production secrets, but the benefit hasn't outweighed the pain. I
think we already solve this problem with good practices:
We don't share secrets between production and development/test
envs.
We specify our production secrets in environment variables.
So we've never been in the habit of committing real secrets to the
repo. It seems strange that we'd slip up and do so now.
Furthermore, as this is only a pre-commit hook, and not a pre-receive
hook, it doesn't actually prevent someone from pushing a secret to
GitHub! Since we have the same vulnerability whether have this hook
or not, I don't think the potential gain (someone gets access to a
production secret, hard-codes it, and then has that commit rejected
before pushing it) is worth the effort (needing to keep the baseline
and pragma comments up to date).
If this PR is accepted, I'll go through our other repos and remove it.