This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Allow facet groups as filter in finder #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteglondon
force-pushed
the
allow-facet-groups-as-filter-in-finder
branch
from
f98e2de
to
74dc63a
Compare
|
I did a fix to make schema tests compile assets before starting, so I think your govt-frontend build should pass now |
steventux
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are replacing
appear_in_find_eu_exit_guidance_business_finderwithfacet_groupstoquery for things appearing in the EU exit business readiness finder,
The schema is preventing us from doing that.
Trello: https://trello.com/c/Sd7omEFH/263-mapping-rummager-request-response-in-finder-frontend