-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDS API Adapters fails to build #389
Comments
Oh interesting, I guess that happens with most gems since they'll often not have a Gemfile.lock on initial cloning. I guess the options we'd want to consider is either only running |
Yep that works great if i comment that out. my bash fu is a little lacking, if you had any starting point on syntax i'd be happy to go test until there's something PR-able? |
Humm or... perhaps we should have the assumption that every repo should have a |
Sure, for lack of a more elegant idea this should do the trick: It feels somewhat more complex to involve gemspecs in the equation if we can avoid it |
A response to issue #389, govuk-docker contains some gems that are needed to use with other applications that tend not to have a Gemfile.lock when initialy cloned. This was causing make (eg. `make gds-api-adapters`) to fail. Here we make the depdency explicit and skip the step if no Gemfile.lock exists, a step that hasn't proved disruptive to using the adapters in other applications.
Sorry had some time off and only just got back on this! |
In this episode of
Will it build
:Steps to reproduce
Join our plucky cast as they attempt to run:
make gds-api-adapters
Stack trace
And encounter the mysterious case of the missing Argument
Also note
So... I suspect this is because the central
Makefile
has an expectation there'll be a Gemfile.lock coming with each package.But in this case gds-api-adapters appears to be a gem itself.
So i guess in this case something more custom in the makefile, (or perhaps another task that focuses on the steps for Gems?) is the route?
The text was updated successfully, but these errors were encountered: