Skip to content

Commit

Permalink
Update glob
Browse files Browse the repository at this point in the history
Fixes a type issue introduced in `@types/node 20.12.11` [1]:

```
node_modules/path-scurry/dist/cjs/index.d.ts:117:31 - error TS2720: Class 'PathBase' incorrectly implements class 'Dirent'. Did you mean to extend 'Dirent' and inherit its members as a subclass?
  Property 'parentPath' is missing in type 'PathBase' but required in type 'Dirent'.

117 export declare abstract class PathBase implements Dirent {
                                  ~~~~~~~~

  node_modules/@types/node/fs.d.ts:247:9
    247         parentPath: string;
                ~~~~~~~~~~
    'parentPath' is declared here.
```

Bump glob, which includes path-scurry as a dependency:

```
$ npm ls path-scurry
@govuk-frontend/repository@ /Users/oliver.byford/Code/govuk-frontend
└─┬ @govuk-frontend/lib@ -> ./shared/lib
  └─┬ glob@10.3.10
    └── path-scurry@1.10.1
```

[1]: isaacs/path-scurry#18
  • Loading branch information
36degrees committed May 28, 2024
1 parent 3d7bfcc commit 4b34423
Show file tree
Hide file tree
Showing 2 changed files with 91 additions and 5 deletions.
94 changes: 90 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@govuk-frontend/config": "*",
"filesize": "^10.1.1",
"glob": "^10.3.10",
"glob": "^10.4.1",
"js-yaml": "^4.1.0",
"minimatch": "^9.0.3",
"nunjucks": "^3.2.4",
Expand Down

0 comments on commit 4b34423

Please sign in to comment.