Skip to content

Commit

Permalink
Move $module inside the base component class
Browse files Browse the repository at this point in the history
  • Loading branch information
romaricpascal committed Aug 18, 2023
1 parent 9f05cea commit 7b3d69a
Show file tree
Hide file tree
Showing 12 changed files with 10 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ import { I18n } from '../../i18n.mjs'
* @preserve
*/
export class Accordion extends GOVUKFrontendComponent {
/** @private */
$module

/**
* @private
* @type {AccordionConfig}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ const DEBOUNCE_TIMEOUT_IN_SECONDS = 1
* @preserve
*/
export class Button extends GOVUKFrontendComponent {
/** @private */
$module

/**
* @private
* @type {ButtonConfig}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ import { I18n } from '../../i18n.mjs'
* @preserve
*/
export class CharacterCount extends GOVUKFrontendComponent {
/** @private */
$module

/** @private */
$textarea

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class Checkboxes extends GOVUKFrontendComponent {
/** @private */
$module

/** @private */
$inputs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class ErrorSummary extends GOVUKFrontendComponent {
/** @private */
$module

/**
* @private
* @type {ErrorSummaryConfig}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import { I18n } from '../../i18n.mjs'
* @preserve
*/
export class ExitThisPage extends GOVUKFrontendComponent {
/** @private */
$module

/**
* @private
* @type {ExitThisPageConfig}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class Header extends GOVUKFrontendComponent {
/** @private */
$module

/** @private */
$menuButton

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class NotificationBanner extends GOVUKFrontendComponent {
/** @private */
$module

/**
* @private
* @type {NotificationBannerConfig}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class Radios extends GOVUKFrontendComponent {
/** @private */
$module

/** @private */
$inputs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class SkipLink extends GOVUKFrontendComponent {
/** @private */
/**
* @protected
* @type {HTMLAnchorElement}
*/
$module

/**
Expand Down
3 changes: 0 additions & 3 deletions packages/govuk-frontend/src/govuk/components/tabs/tabs.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
* @preserve
*/
export class Tabs extends GOVUKFrontendComponent {
/** @private */
$module

/** @private */
$tabs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ import { SupportError } from './errors/index.mjs'
* @abstract
*/
export class GOVUKFrontendComponent {
/**
* @protected
* @type {HTMLElement}
*/
$module

/**
* Constructs a new component, validating that GOV.UK Frontend is supported
*
Expand Down

0 comments on commit 7b3d69a

Please sign in to comment.