Run asset compilation in series (e.g. prevents Rollup conflicts)

alphagov · Sep 12, 2023 · 8f74d02 · 8f74d02
1 parent 16e874b
commit 8f74d02
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/shared/tasks/scripts.mjs b/shared/tasks/scripts.mjs
@@ -16,16 +16,10 @@ export async function compile(pattern, options) {
     cwd: options.srcPath
   })
 
-  // Increase Node.js max listeners warning threshold to silence
-  // Rollup calling `process.on('warning')` once per bundle
-  process.setMaxListeners(1 + modulePaths.length)
-
   try {
-    const compileTasks = modulePaths.map((modulePath) =>
-      compileJavaScript([modulePath, options])
-    )
-
-    await Promise.all(compileTasks)
+    for (const modulePath of modulePaths) {
+      await compileJavaScript([modulePath, options])
+    }
   } catch (cause) {
     throw new PluginError('shared/tasks/scripts', cause)
   }

diff --git a/shared/tasks/styles.mjs b/shared/tasks/styles.mjs
@@ -25,11 +25,9 @@ export async function compile(pattern, options) {
   })
 
   try {
-    const compileTasks = modulePaths.map((modulePath) =>
+    for (const modulePath of modulePaths) {
       compileStylesheet([modulePath, options])
-    )
-
-    await Promise.all(compileTasks)
+    }
   } catch (cause) {
     throw new PluginError('shared/tasks/styles', cause)
   }