Throw MissingElementError if key HTML missing

alphagov · Sep 5, 2023 · b56cebf · b56cebf
1 parent 462146a
commit b56cebf
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/govuk-frontend/src/govuk/components/skip-link/skip-link.mjs b/packages/govuk-frontend/src/govuk/components/skip-link/skip-link.mjs
@@ -1,3 +1,4 @@
+import { MissingElementError } from '../../errors/index.mjs'
 import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'
 
 /**
@@ -33,7 +34,7 @@ export class SkipLink extends GOVUKFrontendComponent {
     // Check for linked element
     const $linkedElement = this.getLinkedElement()
     if (!$linkedElement) {
-      return
+      throw new MissingElementError('The linked HTML element does not exist')
     }
 
     this.$linkedElement = $linkedElement

diff --git a/packages/govuk-frontend/src/govuk/components/skip-link/skip-link.test.js b/packages/govuk-frontend/src/govuk/components/skip-link/skip-link.test.js
@@ -81,5 +81,19 @@ describe('Skip Link', () => {
         message: 'GOV.UK Frontend is not supported in this browser'
       })
     })
+
+    it('throws when the linked element is missing', async () => {
+      await expect(
+        renderAndInitialise(page, 'skip-link', {
+          params: {
+            text: 'Skip to main content',
+            href: '#this-element-does-not-exist'
+          }
+        })
+      ).rejects.toEqual({
+        name: 'MissingElementError',
+        message: 'The linked HTML element does not exist'
+      })
+    })
   })
 })