Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning text icon is squashed with box-sizing: border-box. #1810

Closed
edwardhorsford opened this issue May 18, 2020 · 0 comments · Fixed by #1862
Closed

Warning text icon is squashed with box-sizing: border-box. #1810

edwardhorsford opened this issue May 18, 2020 · 0 comments · Fixed by #1862
Assignees
@36degrees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. warning text
Projects
Design System Sprint Board
Milestone
v3.8.0

Comments

@edwardhorsford
Copy link
Contributor

The warning text icon seems to require a specific box-model. If box model is set to border-box for all elements in a service, this is what you get:

Screenshot 2020-05-15 at 18 27 08

Inspecting in Chrome, it looks like the default box model is content-box.

I'm happy to attempt a fix at this if that's helpful. I'd guess one of these two options:

  • Explicitly set a box model for the icon
  • More explicitly set the size so it doesn't rely on the box model.
@timpaul timpaul added the awaiting triage Needs triaging by team label May 18, 2020
@kellylee-gds kellylee-gds removed the awaiting triage Needs triaging by team label May 18, 2020
@suzannehamilton suzannehamilton mentioned this issue Jun 30, 2020
Closed
@36degrees 36degrees added warning text 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. labels Jul 13, 2020
@36degrees 36degrees mentioned this issue Jul 15, 2020
Merged
@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Jul 15, 2020
@36degrees 36degrees self-assigned this Jul 15, 2020
@36degrees 36degrees moved this from Upcoming sprints to Needs review in Design System Sprint Board Jul 15, 2020
@36degrees 36degrees moved this from Needs review to Ready to release in Design System Sprint Board Jul 16, 2020
@36degrees 36degrees added this to the v3.8.0 milestone Jul 21, 2020
@vanitabarrett vanitabarrett moved this from Ready to release to Done in Design System Sprint Board Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. warning text
Projects
GOV.UK Design System cycle board
Archived in project
Design System Sprint Board
  
Done 🏁
Milestone
v3.8.0
4 participants
@36degrees @timpaul @edwardhorsford @kellylee-gds