Fix display of warning text icon when border-box box sizing is applied globally #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1862
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1862
vanitabarrett
approved these changes
Jul 16, 2020
If a user applies a global box-sizing reset [1], the warning text icon is 'squished' horizontally as the border is 'accounted for' within the 29px min-width. Explicitly use border-box sizing, as this means that the min-width reflects the actual desired width of the icon, rather than having to factor the border width in separately. As the box-sizing model is now set explicitly, it should display correctly whether the reset is applied or not. Increase the min-width and min-height of the icon to include the border (3px border * 2 in each direction = 6px). [1]: https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/
36degrees
force-pushed
the
box-sizing-warning-icon
branch
from
13b72b8
to
317e339
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user applies a global box-sizing reset, the warning text icon is 'squished' horizontally as the border is 'accounted for' within the 29px min-width.
Explicitly use border-box sizing, as this means that the min-width reflects the actual desired width of the icon, rather than having to factor the border width in separately. As the box-sizing model is now set explicitly, it should display correctly whether the reset is applied or not.
Increase the min-width and min-height of the icon to include the border (3px border * 2 in each direction = 6px).
Fixes #1810
Before
After