Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test components and patterns for complex WCAG 2.2 criteria (target, focus appearance, focus not obscured) #4347

Open
3 of 7 tasks
Tracked by #3040
dav-idc opened this issue Oct 17, 2023 · 3 comments
Assignees
Labels
epic Epics are used in planning project boards to group related stories WCAG 2.2 All items related to WCAG 2.2 update activities

Comments

@dav-idc
Copy link

dav-idc commented Oct 17, 2023

What

In our initial WCAG 2.2 style component and pattern assessment spreadsheet, I listed several entries as needing more testing.

I then promptly forgot about it and we never tested those.

So this is the epic to get those tested and then take action on any pieces that need design, development or guidance updates.

The initial assessment sheet (only look at the rows entries that have Work category = "Testing")

My new testing sheet (this is where the majority of the work will happen)

Why

There's 3 WCAG 2.2 criteria that are a bit more technical and inspection heavy than the others:

  • Focus not obscured
  • Target size (minimum)
  • Focus appearance

Who needs to work on this

Accessibility specialist

Who needs to review this

Developers, Interaction designer

Tasks

  • Create assessment spreadsheet for testing complex WCAG 2.2 criteria
  • Update designs and development based on WCAG 2.2 complex testing
  • Update guidance based on WCAG 2.2 complex testing

WCAG 2.2 issues to resolve

  1. WCAG 2.2 accessibility accessibility-concern header 🐛 bug
    owenatgov
  2. accessibility 🐛 bug
  3. WCAG 2.2 accessibility cookie banner guidance
  4. WCAG 2.2 accessibility accessibility-concern button
  5. WCAG 2.2 accessibility accessibility-concern typography
  6. WCAG 2.2 accessibility accessibility-concern tabs 🐛 bug
  7. WCAG 2.2 accessibility accessibility-concern
@dav-idc dav-idc changed the title Testing for complex WCAG criteria (target, focus appearance) Test components and patterns for complex WCAG 2.2 criteria (target, focus appearance, focus not obscured) Oct 17, 2023
@dav-idc dav-idc added the epic Epics are used in planning project boards to group related stories label Oct 17, 2023
@dav-idc dav-idc self-assigned this Oct 17, 2023
@dav-idc dav-idc added the WCAG 2.2 All items related to WCAG 2.2 update activities label Oct 31, 2023
@dav-idc
Copy link
Author

dav-idc commented Oct 31, 2023

The testing sheet is now complete!
https://docs.google.com/spreadsheets/d/1PpKvhCGZJb1j0ZUUY2ZuA0CBQeu04yFD1bumiL8wGX8/edit?usp=sharing

Next step will be to glean potential Github issues that can be made from the 'focus appearance' entries (rows 31 to 61).

@dav-idc dav-idc assigned stevenjmesser and unassigned dav-idc Nov 1, 2023
@dav-idc
Copy link
Author

dav-idc commented Nov 1, 2023

My final thoughts, for whomever picks this up:

  • assign someone to take over, possibly beeps or an interaction designer
  • definitely finish up those 3 tickets in the task list above ('WCAG 2.2 issues to resolve')
  • decide what to do about the 30 ‘focus appearance’ entries near the bottom of that spreadsheet — there’s a ‘second
  • at a minimum I would strongly recommend we update our focus state or overall styling for:
    • secondary buttons
    • inverse buttons
    • tabs (the rectangular tab bit)
    • black links (back, breadcrumbs)

@owenatgov
Copy link
Contributor

@querkmachine made this comment investigating all our focus states and how well they meet (or don't meet) 2.4.13: focus appearance.

Looking at the testing spreadsheet, it appears that David was slightly more lenient in his interpretation. Most notably for inline links (see the row in the calculator for the check answers pattern for an equivalent visual element to test) David has taken into account the contrast change of the text itself which means it just passes. For everything else, David's testing lines up with @querkmachine's testing.

@querkmachine has recommended that our focus states overall need a more thorough review. The issues I've added to the "issues to resolve" task list are potential quick wins but we should think about how we present our focus states more thoroughly via alphagov/govuk-design-system#3007 at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories WCAG 2.2 All items related to WCAG 2.2 update activities
Projects
None yet
Development

No branches or pull requests

3 participants