Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up warning text component styles #1084

Merged
merged 1 commit into from Dec 6, 2018
Merged

Clean up warning text component styles #1084

merged 1 commit into from Dec 6, 2018

Conversation

andysellick
Copy link
Contributor

  • remove negative margin left and reduce padding left to match

Fixes #1083

@36degrees
Copy link
Member

Thanks very much for picking this up, Andy – the change looks good 👍

Would you mind adding an entry to the CHANGELOG under 'Unreleased'? I think this would count as a fix.

@andysellick
Clean up warning text component styles
2021841 
- remove negative margin left and reduce padding left to match
36degrees
36degrees approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andy! 👍

This'll need one more review from someone on the team and then we can merge it.

NickColley
NickColley approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks a lot Andy 🎨 👨‍🎨

@NickColley NickColley merged commit 37854cd into alphagov:master Dec 6, 2018
@andysellick andysellick deleted the update-warning-text-component-styles branch December 6, 2018 14:13
@NickColley NickColley added this to the [NEXT] milestone Dec 11, 2018
@NickColley NickColley mentioned this pull request Dec 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andysellick @36degrees @NickColley