Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double-escaping example names #1234

Merged
merged 2 commits into from Mar 5, 2019
Merged

Avoid double-escaping example names #1234

merged 2 commits into from Mar 5, 2019

Conversation

colinrotherham
Copy link
Contributor

Just a minor one.

I noticed the example names are already HTML escaped before they hit the macro.

Due to Nunjucks autoescape: true they were being double-escaped.

Before

before

After

after

NickColley
NickColley approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these tweaks 👍

@colinrotherham
Copy link
Contributor Author

Pushed again, I fixed a typo aria-describeby which was in a test as well

36degrees
36degrees approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@36degrees 36degrees merged commit 65911a1 into alphagov:master Mar 5, 2019
@colinrotherham colinrotherham deleted the checkbox-typos-etc branch March 5, 2019 12:17
@EoinShaughnessy EoinShaughnessy mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colinrotherham @36degrees @NickColley