Update footer to take licence text and copyright text

[georgeeker]

No description provided.

[georgeeker]

See:
#1291
#1290

[colinrotherham]

Hi @georgeeker, this will need to have a .text or .html property to work.

See the preview: https://govuk-frontend-review-pr-1314.herokuapp.com/components/footer/with-custom-licence-text/preview

It's not triggering {% if params.licence.html or params.licence.text %}

[colinrotherham]

Can this be added to Nunjucks template too?

[36degrees]

Thanks, @georgeeker!

There's a couple of things that still need thinking about here.

The OGL logo is included as an SVG as part of the footer. With the change as it currently stands, even if you override the copyright text you still get the OGL logo, because it's outside of the {% if %} block:

We could move the {% if %} block to wrap the SVG as well, but:

• this would mean that users overriding the HTML would need to know to wrap their licence in govuk-footer__licence-description
• I think there may be instances where users want to overwrite the copyright text whilst still preserving the OGL logo

Secondly, removing the crest makes the footer a lot smaller, so I think we probably need some design input as to whether that's an issue or not.

There might also again be cases where a user wants to override the copyright text without removing the crest, although it's less of an issue as they only have to include a specific class name on the link, rather than having to redeclare an entire SVG.

[36degrees]

Hi George,

Thanks for your work on this so far. I just wanted to check whether you were interested in carrying on working on this?

If we don't hear from you in the next 7 days then we'll close this PR (keeping things tidy helps us keep track of what's being worked on) but please feel free to re-open if you do want to pick this up again.

Addressing this is something we plan to do, but we've not got capacity to pick up ourselves right now.

Thanks,

Ollie

[36degrees]

As mentioned in the last comment we're going to close this for now, but please feel free to re-open if you want to pick this up again.

Thanks again for your contribution.