Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom attributes on summary list action links #1372

Merged
merged 1 commit into from
May 23, 2019

Conversation

colinrotherham
Copy link
Contributor

We've spotted a requirement in our service to add attributes to the "Check Answers" action links.

I've added support via this pull request. Thanks!

{{ govukSummaryList({
  rows: [
    {
      actions: {
        items: [
          {
            text: 'Edit',
            attributes: {
              'data-attribute-1': 'ABC',
              'data-attribute-2': '123'
            }
          }
        ]
      }
    }
  ]
}) }}

Copy link
Member

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, aside from the YAML change nick's flagged – just one minor comment about the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@colinrotherham
Copy link
Contributor Author

colinrotherham commented May 22, 2019

@36degrees @NickColley All sorted. Thanks for the quick review

Copy link
Member

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tickity tick tick ✅

Thanks, @colinrotherham!

@NickColley NickColley merged commit e1fb239 into alphagov:master May 23, 2019
@NickColley NickColley modified the milestone: Next May 23, 2019
@colinrotherham colinrotherham deleted the action-link-attributes branch May 23, 2019 14:47
@NickColley NickColley added this to the v2.12.0 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants