Ensure legacy styles do not override button active state #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional selector only when GOV.UK Template is loaded to ensure it does not override GOV.UK Frontend's active state. This was missed because the links are all visited which gives the selectors a higher specificity.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1564
36degrees
approved these changes
Sep 10, 2019
|
@36degrees yeah, I'm not sure how we fixed it there but not in the default variation, is a bit of a weird one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug only impacts users that are using the legacy project GOV.UK Template alongside GOV.UK Frontend.
Add additional selector only when GOV.UK Template is loaded to ensure it does not override GOV.UK Frontend's active state.
This was missed because the links are all visited which gives the selectors a higher specificity.
To reproduce this you will need to change the link href in the example yaml file so that is not a visited link.
All link styles tested
Fixes #1562