Add display none override class #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes users need to hide elements without wanting to use inline styles. The [hidden] attribute is a good way to do this but needs patching with custom code and will not behave as expected in Internet Explorer 8.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1586
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users need to hide elements without wanting to use inline styles.
The [hidden] attribute is a good way to do this but needs patching with custom code and will not behave as expected in Internet Explorer 8.
This pull requests adds the new override class
.govuk-!-display-noneto help users who do not want to use[hidden].Why not
govuk-hidden?We already have classes for display:
.govuk-!-display-inline.govuk-!-display-inline-block.govuk-!-display-blockSo while
govuk-hiddenis consistent withgovuk-visually-hidden, adding a new override feels more appropriate in this case.Resolves #1060