Fix classes on character count when in error state #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1631
The template correctly adds whitespace between classnames when either the `—error` modifier is added or when custom classes are added, but not when both are added. This means for example that if you were passing the custom class `app-character-count--custom-modifier` to the character count component whilst it was in an error state, the resulting class attribute would be `govuk-js-character-count govuk-textarea--errorapp-character-count--custom-modifier` – neither the error styling nor the custom class would be correctly applied. Fixes #1630
36degrees
force-pushed
the
fix-character-count-classes
branch
from
58cc438
to
1e1d5c2
Compare
hannalaakso
moved this from Needs review
to Ready to release
in Design System Sprint Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template correctly adds whitespace between classnames when either the
—errormodifier is added or when custom classes are added, but not when both are added.This means for example that if you were passing the custom class
app-character-count--custom-modifierto the character count component whilst it was in an error state, the resulting class attribute would begovuk-js-character-count govuk-textarea--errorapp-character-count--custom-modifier– neither the error styling nor the custom class would be correctly applied.Fixes #1630