Fix problem with fsevents@1.2.7 and Node.js 12 #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning `postcss-pseudo-classes@0.2.0` due to “Expected closing parenthesis” blacklist config issue
36degrees
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Thanks, @colinrotherham – really appreciate your work on this. This just needs a second set of eyes and then we can get this merged
|
No problem! Also held back |
NickColley
reviewed
Nov 25, 2019
| @@ -5,7 +5,7 @@ const configPaths = require('../../config/paths.json') | |||
| // Watch task ---------------------------- | |||
| // When a file is changed, re-run the build task. | |||
| // --------------------------------------- | |||
| gulp.task('watch', () => { | |||
There was a problem hiding this comment.
I don't believe this change is necessary as it was a problem with my computer, sorry!
There was a problem hiding this comment.
If an error does happen in watch in future you'll want the promise to reject and be fed back to gulp so it can handle it correctly. Sure you don't want to leave it in?
There was a problem hiding this comment.
Sounds useful to me so can leave it in sure.
NickColley
approved these changes
Nov 25, 2019
Doesn’t need to watch for changes in ./package
|
Thanks for tidying this all up, very good improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
This pull fixes
node-gypbuild issues in #1662I've also pinned
postcss-pseudo-classes@0.2.0as the 0.2.1 update throws an “Expected closing parenthesis” error due to the current blacklist for the:not()selector hack.Breaking but not breaking changes
Also included because they're major semver bumps, but aren't breaking for GOV.UK Frontend: