Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify HTML for a navigation item #1819

Merged

Conversation

adamsilver
Copy link
Contributor

No description provided.

@36degrees
Copy link
Member

36degrees commented May 28, 2020

@adamsilver Thanks for raising this.

Before this can be merged, we'll need to:

  • add html to the params list in /src/govuk/components/header/header.yaml:

    - name: navigation
    type: array
    required: false
    description: An array of navigation item objects.
    params:
    - name: text
    type: string
    required: false
    description: Text of the navigation item.

  • add a test for this behaviour to /src/govuk/components/header/template.test.js

  • document this as an unreleased new feature in /CHANGELOG.md

Are any of those things that you're comfortable doing?

@adamsilver adamsilver force-pushed the adam-header-navigation-item-html branch from 46643cb to f5dbdaf Compare May 28, 2020 11:20
Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
@36degrees 36degrees requested a review from m-green May 28, 2020 12:44
@36degrees 36degrees added this to the v3.7.0 milestone May 28, 2020
@36degrees 36degrees merged commit 9d04359 into alphagov:master May 28, 2020
@36degrees 36degrees mentioned this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants