Explicitly set outline-offset to remove 1px transparent border in chrome v84 #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1879
|
Hi @rorywilsonros ! Thank you, really speedy work raising this. I'm happy to approve this, just a couple of tidy-up tweaks needed:
|
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1879
|
Hi @vanitabarrett - thanks for the review and comments. I've squashed the commits, but would prefer you to add the changelog if that's ok? Best |
…ome > 84 Chrome 83 appears to have changed the default outline-offset to 1px, which then adds a transparent border to the skip link. This explicitly sets it to 0 to hide that border. Fix error due to linting rule removed 'px' for 0 value
36degrees
approved these changes
Jul 23, 2020
Merged
tombye
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Nov 17, 2022
This was fixed by changes in v3.5.0 and v3.8.0 (the comment was wrong): https://github.com/alphagov/govuk-frontend/releases/tag/v3.5.0 https://github.com/alphagov/govuk-frontend/releases/tag/v3.8.0 See specific commits: alphagov/govuk-frontend#1676 alphagov/govuk-frontend#1879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome appears to have changed the default outline-offset to 1px, which then adds a transparent border to the skip link. This explicitly sets it to 0 to hide that border.