Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update param descriptions for notification banner #2024

Merged
merged 1 commit into from Nov 19, 2020

Conversation

36degrees
Copy link
Member

@36degrees 36degrees commented Nov 18, 2020

These have now been 2i'ed, and are taken from this Google Doc.

馃憠馃徎 聽 Preview in the Design System

Co-authored-by: Eoin Shaughnessy <eoin.shaughnessy@digital.cabinet-office.gov.uk>
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@36degrees 36degrees merged commit a5da918 into feature/notification-banner Nov 19, 2020
@36degrees 36degrees deleted the notification-banner-params branch November 19, 2020 09:08
@36degrees 36degrees linked an issue Nov 19, 2020 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalise notification banner macro options documentation
3 participants