Change visited state for error summary and notification banner #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2027
36degrees
reviewed
Nov 19, 2020
vanitabarrett
force-pushed
the
no-visited-state-banners
branch
from
8ff6bc5
to
832ab32
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2027
We recommend not having a different visited link state where it is not helpful to distinguish between visited and unvisited states, for example when linking to pages with frequently-changing content such as the dashboard for an admin interface. It doesn't seem useful to highlight visited links in the notification banner, and the previous behaviour for the error summary also matches this. Therefore this commit updates the error and success link style mixins so that the visited colour is the same as the original link colour.
vanitabarrett
force-pushed
the
no-visited-state-banners
branch
from
832ab32
to
578a224
Compare
36degrees
approved these changes
Nov 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recommend not having a different visited link state where it is not helpful to distinguish between visited and unvisited states, for example when linking to pages with frequently-changing content such as the dashboard for an admin interface.
It doesn't seem useful to highlight visited links in the notification banner, and the previous behaviour for the error summary also matches this.
Therefore this commit updates the error and success link style mixins so that the visited colour is the same as the original link colour.