Fix hairline gap between notification banner header and outer border on high resolution screens in Chrome/Edge (Blink) #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2035
36degrees
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Looks good to me – thanks @andymantell
My only concern was around High Contrast Mode but visually it seems to behave exactly the same:
Before
After
This just needs another review from another member of the team and then we can get this merged.
|
Thanks @andymantell , good spot and this fix looks good to me! Would you be able to add a quick entry in the Changelog too? Something similar to this example. |
|
Thanks both. Will changelog it now... |
andymantell
changed the title
vanitabarrett
approved these changes
Nov 25, 2020
|
Thanks for the really clear update to the PR title 👍🏻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2034 (White line around notification banner heading on high DPI screens in chrome) I have flipped the colouring of the notification banner around. This means the background colour of the entire notification banner is now blue/green, but the content container inside it is white - meaning there is no gap between the two any more.
I had to remove bottom margin from the last child inside the content div - reason being I had to switch the content container to padding instead of margins but that causes it to contain the bottom margin of the last child.