Use pointer cursor for 'Menu' button in header #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New CSS to change the cursor to pointer when hovered over, as per any other link, including other links in the header. An edge case perhaps because this will presumably mostly be for mobile, but for desktops with a narrow window, or heavily zoomed in, a pointer cursor will be consistent with other links.
36degrees
changed the title
36degrees
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Makes sense to me – this is consistent with the cursor on both links and buttons elsewhere.
I've taken the liberty of squashing the commits down to 1 and adding a changelog entry – hope that's OK.
This just needs a review from a second member of the team and then we can get this merged – maybe @christopherthomasdesign could take a look?
vanitabarrett
moved this from Done 🏁
to Ready to release 🚀
in Design System Sprint Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cursor is
defaultwhen hovering over the menu button in the header. An edge case perhaps because this will presumably mostly be for mobile. But users on desktops with a narrow window, or when heavily zoomed in, will have an inconsistent experience.This change adds one line of CSS to change the cursor to
pointerwhen hovered over, as per any other link, including other links in the header.