Iterate full page examples of cookie banners in the review app #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
36degrees
approved these changes
Mar 9, 2021
Base automatically changed from
enable-cookie-banner-to-set-link-as-button
to
master
March 10, 2021 17:43
Fixes a JavaScript error currently in the review app: ``` Uncaught TypeError: Cannot read property 'addEventListener' of null` ```
If the user chooses hides the confirmation banner, progressively enhance the cookie banner to hide with JavaScript. If JavaScript is not enabled, the page reloads.
Add an example of a typical essential cookies only banner that works both on client and server side. When the user hides the cookie banner, we progressively enhance the cookie banner to hide with JavaScript. If JavaScript is not enabled, the form is submitted and a page navigation occurs. To enable progressive enhancement, we include a small amount of client-side JavaScript to handle the ‘Hide’ button in the example. The cookie banner component itself does not ship with JavaScript. Typically the service team needs to write the code that hides the banner and integrates the collection of cookies both in JavaScript and on the server.
hannalaakso
force-pushed
the
iterate-review-app-cookie-banner-examples
branch
from
f92aae5
to
375ae15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate the full page cookie banner examples in the review app to help us iterate the cookie banner guidance.
This PR:
This PR depends on #2164 so should be merged after it.
Closes #2160