Update cookie macros about links styled as buttons #2168
Conversation
EoinShaughnessy
added
the
documentation
There was a problem hiding this comment.
👍 Looks good to me, but I'll let @hannalaakso take a final look as she's been working on those changes
@vanitabarrett Thanks! Yeah, got the nod from @hannalaakso earlier. |
|
This content has passed 2i. |
EoinShaughnessy
added
the
🕔 hours
EoinShaughnessy
force-pushed
the
button-links-content
branch
from
f459ea2
to
aed0362
Compare
|
@hannalaakso I've added the Changelog update to this PR. Should I squash the 2 commits here, or would it be better to leave them be, because they represent changes to 2 different docs (the cookie macros and the Changelog)? Also - do we have to merge this PR before we add any other updates to the Changelog? Or are we also going to use this PR for those updates? |
CHANGELOG.md
Outdated
| You can now add links styled as buttons to cookie banners. | ||
|
|
||
| Use this feature only if you need to. For example, you can set the **Hide** button to be a link styled as a button that reloads the page. You might want to do this if the cookie banner needs to work without JavaScript and the **Hide** button does not need to set a cookie, as the user has already accepted or rejected cookies. | ||
| - the user has already accepted or rejected cookies - so, when they press **Hide** and the page reloads, the banner is hidden |
There was a problem hiding this comment.
| - the user has already accepted or rejected cookies - so, when they press **Hide** and the page reloads, the banner is hidden |
EoinShaughnessy
force-pushed
the
button-links-content
branch
from
e896bdf
to
f30239c
Compare
|
@hannalaakso I've reduced the commits to 2 (1 for the Changelog update, 1 for the macros update). Can I get a review? :) |
No description provided.