Update tabs to use core link mixin #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabs are progressively enhanced from a set of links, which is what users see if JavaScript is not enabled. Apply the common link styles mixin, which includes the new link style treatments, to the tabs. The common link styles mixin also includes the focus state, so we no longer need to apply that separately. When we progressively enhance the tabs, the only thing we then need to change about the links is the link colour, which is already handled by the inclusion of the `govuk-link-style-text` mixin. Using the text link style mixin for this component prepares us for the new link styles which will now be inherited from the mixins.
36degrees
force-pushed
the
tab-link-styles
branch
from
4c1d169
to
b76bfaf
Compare
36degrees
changed the title
hannalaakso
approved these changes
Apr 29, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs are progressively enhanced from a set of links, which is what users see if JavaScript is not enabled.
Apply the common link styles mixin, which includes the new link style treatments, to the tabs. The common link styles mixin also includes the focus state, so we no longer need to apply that separately.
When we progressively enhance the tabs, the only thing we then need to change about the links is the link colour, which is already handled by the inclusion of the
govuk-link-style-textmixin.Using the text link style mixin for this component prepares us for the new link styles which will now be inherited from the mixins.
There should be no visual change to the component.
Split out from #2183.