Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the border from the last item in the collapsible navigation menu in the header #2448

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

36degrees
Copy link
Member

@36degrees 36degrees commented Nov 29, 2021

Split out from #2427, and builds on #2447 which needs to be merged first.

Breakpoint Before After
Mobile mobile-before mobile-after
Tablet tablet-before tablet-after

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2448 November 29, 2021 16:40 Inactive
@36degrees 36degrees changed the title Remove border from last item in header menu Remove the border from the last item in the collapsible navigation menu in the header Nov 29, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2448 November 29, 2021 16:41 Inactive
@36degrees 36degrees marked this pull request as draft December 1, 2021 11:18
@36degrees 36degrees force-pushed the header-navigation-bottom-border branch from f32e680 to a3ce360 Compare December 1, 2021 11:19
@36degrees 36degrees changed the base branch from main to header-tablet-margin December 1, 2021 11:20
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2448 December 1, 2021 11:20 Inactive
Base automatically changed from header-tablet-margin to main December 1, 2021 12:00
@36degrees 36degrees marked this pull request as ready for review December 1, 2021 12:00
@36degrees 36degrees merged commit 7fce84c into main Dec 1, 2021
@36degrees 36degrees deleted the header-navigation-bottom-border branch December 1, 2021 17:43
@vanitabarrett vanitabarrett mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants