Use Element.id to get module id for accordion #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2811
Use the native `Element.id` IDL property (supported by all modern browsers including IE6+) rather than `Element.getAttribute('id')`
As `this.moduleId` is only used once, replace it with a call to `this.$module.id`.
36degrees
force-pushed
the
accordion-module-id
branch
from
c785317
to
f846c05
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2811
querkmachine
approved these changes
Aug 26, 2022
|
Just to record that I've tested this in IE8 through 11 (by inspecting the button and ensuring that I've not tested in any other browsers other than Chrome 104 as my day-to-day browser. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the native
Element.idIDL property (supported by all modern browsers including IE6+) rather thanElement.getAttribute('id')As
this.moduleIdis only used once, replace it with a call tothis.$module.id.