Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CharacterCount component to receive i18n config via JS #2887

Merged
merged 14 commits into from
Oct 11, 2022
Merged

Allow CharacterCount component to receive i18n config via JS #2887

merged 14 commits into from
Oct 11, 2022

Commits on Oct 11, 2022

  1. Refactor character count message generation 

    Introduce a function focused on formatting the message to help with testing
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    ed82784 View commit details
    Browse the repository at this point in the history

  2. Add unit test for count message formatting

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    fcd3ec1 View commit details
    Browse the repository at this point in the history

  3. Use I18n for formatting count message

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    9e8e2d1 View commit details
    Browse the repository at this point in the history

  4. Add test for passing different translations

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0400810 View commit details
    Browse the repository at this point in the history

  5. Add tests for formatting of numbers in CharacterCount 

    Provided by the I18n object
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    71b7a3b View commit details
    Browse the repository at this point in the history

  6. Add separate translation key when limit is met

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    88fcbc3 View commit details
    Browse the repository at this point in the history

  7. Default character count locale to closest 'lang' attribute 

    Commit is a bit bulky for what sounds a simple thing, but it's mostly behind the scene logistics:
- extracting the helper for creating dom elements in its own file
- introducing a function to get the value of an attribute from the closest parent with it
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    66d8a1b View commit details
    Browse the repository at this point in the history

  8. Update JSDoc

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    74d3b94 View commit details
    Browse the repository at this point in the history

  9. Rewrite test checking the closestAttributeValue reads up the DOM tree 

    Make the HTML structure more apparent than creating a series of elements manually
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    5fe3fc5 View commit details
    Browse the repository at this point in the history

  10. Remove configuration of locale via JavaScript

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    152c562 View commit details
    Browse the repository at this point in the history

  11. Tidy up character count translation tests

    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    10d6bc2 View commit details
    Browse the repository at this point in the history

  12. Revert translation string for when limit is met 

    Updates the testing to use the JavaScript configuration
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a2a4934 View commit details
    Browse the repository at this point in the history

  13. Remove dom-helpers 

    Waiting for further discussion about abstraction in #2894
    @romaricpascal
    romaricpascal committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4dcdeae View commit details
    Browse the repository at this point in the history

  14. Fix out of sync values in JSDoc 

    Co-authored-by: Colin Rotherham <work@colinr.com>
    @romaricpascal @colinrotherham
    romaricpascal and colinrotherham committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a5ed606 View commit details
    Browse the repository at this point in the history