Add polyfill for String.prototype.trim
#2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bc843a3 (#2840) we introduced a new `normaliseString` helper method [1] which relies on `String.prototype.trim` [2], which is not supported in IE8 or IE9 [3] This causes a script error when going to any page in the review app (in IE8) which contains a component that accepts config via data attributes. Add a polyfill for String.prototype.trim based on the polyfill that used to be on MDN [4] (before they removed content relating to IE8), adapted to match the format used for the existing polyfills. [1]: https://github.com/alphagov/govuk-frontend/blob/cf7b06ceb19236a9afeb5399158b35391219cf99/src/govuk/common.mjs#L152 [2]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim [3]: https://caniuse.com/mdn-javascript_builtins_string_trim [4]: https://github.com/mdn/content/blob/cf607d68522cd35ee7670782d3ee3a361eaef2e4/files/en-us/web/javascript/reference/global_objects/string/trim/index.md#polyfill
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2908
colinrotherham
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Approving, but subject to us updating the sideEffects package field
To summarise a conversation on Slack:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bc843a3 (#2840) we introduced a new
normaliseStringhelper method which relies onString.prototype.trim, which is not supported in IE8 or IE9.This causes a script error when going to any page in the review app (in IE8) which contains a component that accepts config via data attributes.
Add a polyfill for
String.prototype.trimbased on the polyfill that used to be on MDN (before they removed content relating to IE8), adapted to match the format used for the existing polyfills.Closes #2903.