Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit polyfill impact on bundle size to components that actually import them #2959

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Limit polyfill impact on bundle size to components that actually import them #2959

merged 3 commits into from
Nov 7, 2022

Commits on Nov 7, 2022

  1. Move normaliseDataset in its own module 

    This'll allow the polyfill it requires to be tree-shaken properly when bundling components
that require common.mjs
    @romaricpascal
    romaricpascal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    05101d8 View commit details
    Browse the repository at this point in the history

  2. Move closestAttributeValue into its own module 

    Allows the polyfill it requires to be tree-shaken properly
when components that don't use it import `common.mjs`
    @romaricpascal
    romaricpascal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7dd00b1 View commit details
    Browse the repository at this point in the history

  3. Move common.mjs implementation into the common folder 

    Leaves the `common.mjs` file to re-export it so that code importing it from the current release still find it
    @romaricpascal
    romaricpascal committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0a87bbf View commit details
    Browse the repository at this point in the history