Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Autoprefixer v10 #3243

Closed
wants to merge 1 commit into from
Closed

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Feb 3, 2023

We recently set up our CSS minifier CSSNANO to run after our PostCSS transforms:

Turns out this mostly unblocked the following upgrade:

  1. Autoprefixer v10 (see release notes)

But I'll leave this PR in draft as the Review app's IE8 stylesheets have incompatible PostCSS plugins

This PR is now ready for review thanks to:

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3243 February 3, 2023 08:29 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3243 February 3, 2023 09:20 Inactive
@colinrotherham colinrotherham marked this pull request as draft February 3, 2023 09:22
@colinrotherham colinrotherham changed the base branch from main to cssnano-only February 3, 2023 09:40
@colinrotherham colinrotherham changed the title Upgrade to Autoprefixer v10 + CSSNANO v5 Upgrade to Autoprefixer v10 Feb 3, 2023
@colinrotherham colinrotherham changed the title Upgrade to Autoprefixer v10 [SPIKE] Upgrade to Autoprefixer v10 Feb 3, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3243 February 9, 2023 13:23 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3243 February 9, 2023 13:29 Inactive
Base automatically changed from cssnano-only to main February 10, 2023 10:28
@colinrotherham colinrotherham self-assigned this Apr 4, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3243 May 4, 2023 12:47 Inactive
@colinrotherham colinrotherham changed the title [SPIKE] Upgrade to Autoprefixer v10 Upgrade to Autoprefixer v10 May 4, 2023
@colinrotherham colinrotherham changed the base branch from main to remove-ie8-css May 4, 2023 12:48
@colinrotherham colinrotherham marked this pull request as ready for review May 4, 2023 12:50
Base automatically changed from remove-ie8-css to main May 4, 2023 14:04
@colinrotherham
Copy link
Contributor Author

We can let Dependabot deal with this now 🎉

@colinrotherham colinrotherham deleted the cssnano-autoprefixer branch May 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants