Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organisation brand colour for Department for Business & Trade #3426

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Add organisation brand colour for Department for Business & Trade #3426

merged 1 commit into from
Mar 28, 2023

Conversation

baisa
Copy link
Contributor

@baisa baisa commented Mar 27, 2023

This change is to update labelling of Department of International Trade to Department for Business & Trade.

Trello card

@colinrotherham colinrotherham added the awaiting triage Needs triaging by team label Mar 28, 2023
@querkmachine
Copy link
Member

Hi @baisa,

Are you able to update this so that department-for-business-and-trade is added as a new section, without removing department-for-international-trade? This will prevent things breaking if they're still looking for colours associated with the older name.

@baisa
Update the labelling of Department of International Trade to Departme…
995412c 
…nt for Business & Trade

This change follows the updates to departments.
@baisa baisa force-pushed the Update-Department-of-Business-and-Trade-branding-labels branch from fd0a66b to 995412c Compare March 28, 2023 12:18
@baisa
Copy link
Contributor Author

baisa commented Mar 28, 2023

Hi @baisa,

Are you able to update this so that department-for-business-and-trade is added as a new section, without removing department-for-international-trade? This will prevent things breaking if they're still looking for colours associated with the older name.

Sure, thank you @querkmachine

querkmachine
querkmachine approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@querkmachine querkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just needs a second approval from someone on the team and we can merge it!

romaricpascal
romaricpascal approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me as well, let's merge it 😄

@romaricpascal romaricpascal merged commit 294971d into alphagov:main Mar 28, 2023
@36degrees 36degrees changed the title Support government changes - Update the labelling Add organisation brand colour for Department for Business & Trade Mar 28, 2023
36degrees added a commit that referenced this pull request Mar 28, 2023
@36degrees
Add changelog entry for #3426
b6c9794
36degrees added a commit that referenced this pull request Mar 28, 2023
@36degrees
Merge pull request #3429 from alphagov/changelog-3426
6c64f44 
Add changelog entry for #3426
@romaricpascal romaricpascal mentioned this pull request Apr 20, 2023
Merged
@colinrotherham colinrotherham removed the awaiting triage Needs triaging by team label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaricpascal romaricpascal romaricpascal approved these changes

@querkmachine querkmachine querkmachine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baisa @querkmachine @romaricpascal @colinrotherham