Update default link underline offset setting #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
force-pushed
the
link-underline-offset-change
branch
from
7cfc050
to
62275b6
Compare
colinrotherham
approved these changes
Mar 30, 2023
querkmachine
force-pushed
the
link-underline-offset-change
branch
from
62275b6
to
3260331
Compare
|
Chris reviewed and approved via Slack. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced new link styles in #2183 (GOV.UK Frontend v3.12.0), however were forced to compromise on the underline offset due to a bug in the Chromium rendering engine.
That bug was fixed in May 2022, was released in Chrome 104/Edge 104, and is now widely available. As such, we are updating the default link underline offset to achieve the originally intended appearance.
Closes #2743.