Remove unnecesary class from Warning Text component #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
force-pushed
the
warning-text-remove-unnecessary-class
branch
from
b452727
to
e81138d
Compare
colinrotherham
approved these changes
May 2, 2023
Merged
jrmhaig
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Feb 28, 2024
This class is replaced with govuk-visually-hidden. See alphagov/govuk-frontend#3569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
govuk-warning-text__assistiveclass in the Warning Text component is redundant. It applies exactly the same styles asgovuk-visually-hiddenwithout any variation in code or purpose, and is not referenced by any JS functionality outside of tests.This PR replaces the component's bespoke class with the global
govuk-visually-hiddenclass.As this is an alteration to the HTML, it's a breaking change for any users not using Nunjucks macros.
This is how the equivalent GOV.UK Elements component styled it. The bespoke class was added when the component was ported into the Design System, but it served the same purpose even then.
Closes #3553.