Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated static spacing classes #3593

Merged
merged 1 commit into from
May 9, 2023

Conversation

querkmachine
Copy link
Member

Removes the erroneously named .govuk-!-margin-static and .govuk-!-padding-static classes introduced in v4.3.0 and deprecated in v4.3.1.

Closes #2782.

@querkmachine querkmachine self-assigned this May 9, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3593 May 9, 2023 10:43 Inactive
@querkmachine querkmachine force-pushed the remove-misnamed-static-classes branch from 6f66581 to 664dc1d Compare May 9, 2023 10:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3593 May 9, 2023 10:44 Inactive
@querkmachine querkmachine marked this pull request as ready for review May 9, 2023 10:47
@querkmachine querkmachine requested a review from a team May 9, 2023 10:47
Copy link
Member

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the best 'deleting things' I've seen today 🤪 👏🏻

Have suggested some minor tweaks to the release note but I don't consider them blocking.

CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3593 May 9, 2023 10:59 Inactive
Removes the erroneously named `.govuk-!-margin-static` and `.govuk-!-padding-static` classes added in v4.3.0 and deprecated in v4.3.1.

Update CHANGELOG.md

Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
@querkmachine querkmachine force-pushed the remove-misnamed-static-classes branch from f3faef5 to f1f978d Compare May 9, 2023 10:59
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3593 May 9, 2023 11:00 Inactive
@querkmachine querkmachine merged commit 3462066 into main May 9, 2023
21 checks passed
@querkmachine querkmachine deleted the remove-misnamed-static-classes branch May 9, 2023 11:06
@romaricpascal romaricpascal mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated govuk-!-margin-static and govuk-!-padding-static classes
3 participants